Remove connection from config for EventSubscribers #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I realized the config used for the tests doesn't define the connection so it shouldn't be an issue: |
julienbourdeau
force-pushed
the
config/remove-connection-name
branch
2 times, most recently
from
c73a4a3 to
ee57363
Compare
julienbourdeau
force-pushed
the
config/remove-connection-name
branch
from
ee57363 to
4ad372e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
In service configuration, I removed the
connectionattribute for the eventSubscriber. As far as I understand, if you have multiple connections, they will all be used but this should be tested more in-depth.I'm still unsure if this should be considered breaking from a SEMVER stand point
What problem is this fixing?
If your symfony doesn't have a connection called
default, it would break.