Make AlgoliaClient lazy #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
force-pushed
the
feat/lazy-client
branch
from
e88f2db to
6734808
Compare
This was referenced Aug 27, 2018
alcaeus
suggested changes
Aug 27, 2018
composer.json
Outdated
| "symfony/property-access": "^3.4.0 || ^4.0.0", | ||
| "symfony/filesystem": "^3.4.0 || ^4.0.0" | ||
| "symfony/filesystem": "^3.4.0 || ^4.0.0", | ||
| "ocramius/proxy-manager": "*", |
Contributor
There was a problem hiding this comment.
Generally, it's left to the user to include these packages if they want to use lazy functionality. I would not recommend including them in a vendor package, even less so without a useful version constraint.
Contributor
Author
There was a problem hiding this comment.
Hi @alcaeus 👋 , thanks for reviewing.
I didn't see it this way, but that's even better. I'll move them to require-dev and add a note in the doc.
OskarStark
approved these changes
Aug 27, 2018
julienbourdeau
force-pushed
the
feat/lazy-client
branch
from
6734808 to
cacbd35
Compare
julienbourdeau
force-pushed
the
feat/lazy-client
branch
from
cacbd35 to
ffbd21b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
algolia_clientservice (API Client class) is now lazy.What problem is this fixing?
Avoid error message if Algolia env variables aren't defined when doing other operations, not related to Algolia (like emptying cache).
See #241, #199