-
Notifications
You must be signed in to change notification settings - Fork 73
chore: add native return types #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3bef9dd to
987f22c
Compare
|
I had to revert the changes made in #364, as it turns out the change wouldn't work for Symfony v6: the definition for Symfony's |
|
Any news? This PR will allow us to upgrade to Symfony 6. I think a lot of people have the same issue. |
|
I'll bring this up during our upcoming team discussions, and keep you posted on the outcome 🙂 |
|
Some news on this PR ? |
Hey @DevinCodes could you give us a rough estimate on the ETA since the patch is ready. Feel free to ask if you want some help. |
|
Hi all! We'll need to release a new major that only supports modern versions of Symfony. I'll prepare the release for this tomorrow, and I'll try to get it out before the weekend! |
damcou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
|
Merging this and releasing tomorrow! |
Describe your change
This adds native return types to some methods to prevent Symfony from raising deprecation warnings.