Skip to content

Conversation

@DevinCodes
Copy link
Contributor

@DevinCodes DevinCodes commented Dec 20, 2021

Q A
Bug fix? no
New feature? no
BC breaks? yes

Describe your change

This adds native return types to some methods to prevent Symfony from raising deprecation warnings.

@DevinCodes DevinCodes force-pushed the fix/return-annotations branch from 3bef9dd to 987f22c Compare December 20, 2021 14:47
@DevinCodes
Copy link
Contributor Author

I had to revert the changes made in #364, as it turns out the change wouldn't work for Symfony v6: the definition for Symfony's NormalizableInterface is not backwards compatible with older PHP versions, meaning that we need to introduce a new major version in order to add support for symfony v6 and up. This would break compatibility for older versions. cc @damcou

@Bukashk0zzz
Copy link

Any news? This PR will allow us to upgrade to Symfony 6. I think a lot of people have the same issue.
From what I see in other repositories, there is no other way than introduce a new major version with ^5.4|^6.0 support only.

@DevinCodes
Copy link
Contributor Author

I'll bring this up during our upcoming team discussions, and keep you posted on the outcome 🙂

@Kaaly
Copy link
Contributor

Kaaly commented Jan 24, 2022

Some news on this PR ?

@barrycarton
Copy link

barrycarton commented Jan 25, 2022

I'll bring this up during our upcoming team discussions, and keep you posted on the outcome 🙂

Hey @DevinCodes could you give us a rough estimate on the ETA since the patch is ready. Feel free to ask if you want some help.

@DevinCodes
Copy link
Contributor Author

Hi all! We'll need to release a new major that only supports modern versions of Symfony. I'll prepare the release for this tomorrow, and I'll try to get it out before the weekend!

@DevinCodes DevinCodes requested a review from damcou January 27, 2022 15:26
Copy link

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@DevinCodes
Copy link
Contributor Author

Merging this and releasing tomorrow!

@DevinCodes DevinCodes merged commit d1840b8 into master Jan 27, 2022
@DevinCodes DevinCodes deleted the fix/return-annotations branch January 27, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants