fix: update oauth flow to use redirect callback instead of sending messages from popup window#136
Merged
fix: update oauth flow to use redirect callback instead of sending messages from popup window#136
Conversation
Ingenieralejo
pushed a commit
to Ingenieralejo/algora
that referenced
this pull request
Apr 16, 2026
Replace all remaining push_event("open_popup", ...) calls with
redirect(external: socket.assigns.oauth_url) in the 4 files
from the checklist:
- swift_bounties_live.ex (2 occurrences: create_bounty, create_tip)
- crowdfund.ex (2 occurrences: create_bounty, create_tip)
- org/bounties_new_live.ex (1 occurrence: create_bounty)
- org/settings_live.ex (1 occurrence: install_app)
Follows the same pattern established in algora-io#136 and 735485b.
Closes algora-io#137
8 tasks
Ingenieralejo
pushed a commit
to Ingenieralejo/algora
that referenced
this pull request
Apr 16, 2026
Replace all remaining push_event("open_popup", ...) calls with
redirect(external: socket.assigns.oauth_url) in the 4 files
from the checklist:
- swift_bounties_live.ex (2 occurrences: create_bounty, create_tip)
- crowdfund.ex (2 occurrences: create_bounty, create_tip)
- org/bounties_new_live.ex (1 occurrence: create_bounty)
- org/settings_live.ex (1 occurrence: install_app)
Follows the same pattern established in algora-io#136 and 735485b.
Closes algora-io#137
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #135