fix: alternative UI permission fix for bounty admin buttons (#238)#242
Closed
ZackaryShen wants to merge 1 commit intoalgora-io:mainfrom
Closed
fix: alternative UI permission fix for bounty admin buttons (#238)#242ZackaryShen wants to merge 1 commit intoalgora-io:mainfrom
ZackaryShen wants to merge 1 commit intoalgora-io:mainfrom
Conversation
Alternative fix for #238 — adds :if={@current_user_role in [:admin, :mod]} to each admin button individually instead of wrapping the parent div. This ensures the permission check is explicit at the button level, matching the backend authorization logic in handle_event handlers.
|
root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
Also marking as ready for review. The fix adds explicit per-button permission checks matching the backend handler guards. Happy to discuss the approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternative fix for #238 — adds
:if={@current_user_role in [:admin, :mod]}to each admin button individually, rather than wrapping the parent div.Changes
lib/algora_web/live/org/bounties_live.ex: +2 lines:if={@current_user_role in [:admin, :mod]}:if={@current_user_role in [:admin, :mod]}Why This Approach
handle_eventTesting
Backend authorization confirmed working (unauthorized clicks return error toast). No Elixir environment available in current context — please test locally.
Closes #238