Skip to content

fix: raise descriptive error when API returns empty choices list #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: raise descriptive error when API returns empty choices list #436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/cai/sdk/agents/models/openai_chatcompletions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,16 @@ async def get_response(

raise

# Guard against empty choices list which can occur with some API providers
# (e.g. Gemini via OpenAI-compatible endpoint) due to content filtering or
# transient API errors. Raise a clear error instead of an obscure IndexError.
if not response.choices:
raise ValueError(
f"Model '{self.model}' returned a response with no choices. "
"This may be caused by content filtering, rate limiting, or an "
"API compatibility issue with the provider."
)

if _debug.DONT_LOG_MODEL_DATA:
logger.debug("Received model response")
else:
Expand Down