Skip to content

chore: add helm chart close #180#232

Merged
Spground merged 3 commits intoalibaba:mainfrom
Spground:feature/public-add-helm-chart
Mar 2, 2026
Merged

chore: add helm chart close #180#232
Spground merged 3 commits intoalibaba:mainfrom
Spground:feature/public-add-helm-chart

Conversation

@Spground
Copy link
Copy Markdown
Collaborator

@Spground Spground commented Feb 11, 2026

Summary

  • What is changing and why?
  1. add k8s related component image build workflow
  2. add helm chart workflow

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Controller system namespace was updated from sandbox-k8s-system from opensandbox-system, user maybe need to redeploy controller component in new system namespace.

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@Spground Spground added component/k8s For kubernetes runtime packages Changes for package, image and configuration labels Feb 11, 2026
@Spground Spground changed the title Feature/public add helm chart chore: add helm chart Feb 11, 2026
@jwx0925
Copy link
Copy Markdown
Collaborator

jwx0925 commented Feb 11, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2358792f7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/publish-components.yml
Comment thread kubernetes/Makefile
fengcone
fengcone previously approved these changes Feb 12, 2026
@Spground
Copy link
Copy Markdown
Collaborator Author

close #180

@Spground Spground changed the title chore: add helm chart chore: add helm chart close #180 Feb 12, 2026
@Spground Spground self-assigned this Feb 12, 2026
Copy link
Copy Markdown
Collaborator

@jwx0925 jwx0925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the usage instructions in the Kubernetes README to use Helm charts

@Spground
Copy link
Copy Markdown
Collaborator Author

Update the usage instructions in the Kubernetes README to use Helm charts

updated

Pangjiping
Pangjiping previously approved these changes Feb 13, 2026
Comment thread kubernetes/docs/BUILD-IMAGES.md
Comment thread kubernetes/README-ZH.md Outdated
Comment thread kubernetes/charts/opensandbox-controller/README.md Outdated
@jwx0925
Copy link
Copy Markdown
Collaborator

jwx0925 commented Feb 25, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5dcba0c823

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread kubernetes/build.sh Outdated
Comment thread kubernetes/charts/opensandbox-controller/templates/_helpers.tpl Outdated
@Spground Spground force-pushed the feature/public-add-helm-chart branch from 5dcba0c to ec4532a Compare February 25, 2026 07:49
@Spground Spground force-pushed the feature/public-add-helm-chart branch from ec4532a to d147d30 Compare February 25, 2026 08:00
Copy link
Copy Markdown
Collaborator

@jwx0925 jwx0925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spground Spground merged commit 45e2e10 into alibaba:main Mar 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/k8s For kubernetes runtime packages Changes for package, image and configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants