Skip to content

secure container e2e case & guide doc#249

Merged
Spground merged 13 commits intoalibaba:mainfrom
fengcone:feature/public-secure-container
Mar 5, 2026
Merged

secure container e2e case & guide doc#249
Spground merged 13 commits intoalibaba:mainfrom
fengcone:feature/public-secure-container

Conversation

@fengcone
Copy link
Copy Markdown
Collaborator

@fengcone fengcone commented Feb 26, 2026 •
edited
Loading

Summary

  • What is changing and why?

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@fengcone
Copy link
Copy Markdown
Collaborator Author

fengcone commented Feb 26, 2026 •
edited
Loading

see issue #174

hittyt
hittyt reviewed Feb 26, 2026
View reviewed changes
Comment thread kubernetes/test/kind/gvisor/runsc Outdated
Comment thread kubernetes/test/e2e_runtime/gvisor/gvisor_test.go Outdated
Comment thread kubernetes/test/e2e_runtime/gvisor/suite_test.go Outdated
Comment thread kubernetes/test/e2e_runtime/gvisor/testdata/batchsandbox-runtimeclass.yaml Outdated
Comment thread kubernetes/test/e2e_runtime/helpers.go Outdated
@jwx0925
Copy link
Copy Markdown
Collaborator

jwx0925 commented Feb 27, 2026

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ddbf36c86f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread kubernetes/test/e2e_runtime/gvisor/suite_test.go
Comment thread kubernetes/Makefile Outdated
fengcone added 3 commits March 1, 2026 19:25
@fengcone
test(gvisor): add gVisor binaries download and improve cluster setup
041d193 
- Add Makefile target to download gVisor runsc and containerd-shim-runsc-v1 binaries
- Include gVisor binaries in .gitignore to avoid tracking
- Modify setup-gvisor target to depend on binaries download
- Update Kind cluster config file path in Makefile to use new template location
- Enhance Kind cluster creation commands to use downloaded binaries
- Add environment variable KIND_CLUSTER support for gVisor tests
- Improve command comments and error handling in gVisor test suite
- Remove unused RenderTemplate function and unnecessary imports in helpers.go
- Change relative directory comments from Chinese to English in tests
@fengcone
Merge branch 'main' into feature/public-secure-container
3c40b6a
@fengcone
test(e2e_runtime): remove unused gvisor batchsandbox and pool test da…
26dcd90 
…ta YAML files
@fengcone fengcone force-pushed the feature/public-secure-container branch from 5f1004d to 9d0b9cd Compare March 3, 2026 13:53
Spground
Spground reviewed Mar 4, 2026
View reviewed changes
Comment thread server/src/config.py
Comment thread server/src/services/runtime_resolver.py
@fengcone fengcone force-pushed the feature/public-secure-container branch from 9d0b9cd to cd9f468 Compare March 4, 2026 07:27
@fengcone fengcone force-pushed the feature/public-secure-container branch from cd9f468 to a64513c Compare March 4, 2026 07:29
fengcone added 2 commits March 4, 2026 15:33
@fengcone
Merge branch 'main' into feature/public-secure-container
4222dbe 
# Conflicts:
#	kubernetes/Makefile
#	server/README.md
#	server/README_zh.md
#	server/src/main.py
@fengcone
chore(server): add logger instance to main module
696d6ba
@fengcone fengcone force-pushed the feature/public-secure-container branch from 7cf8651 to 696d6ba Compare March 4, 2026 07:46
@fengcone fengcone force-pushed the feature/public-secure-container branch from 6bad9c4 to cd6c8cb Compare March 4, 2026 10:01
@jwx0925
Copy link
Copy Markdown
Collaborator

jwx0925 commented Mar 4, 2026

add this feature to README.md, like this:

  • Strong Isolation: Supports different security runtimes like gVisor, Kata Containers, or Firecracker microVM to provide enhanced security and isolation between sandbox workloads and the host. See doc ....

@jwx0925
Copy link
Copy Markdown
Collaborator

jwx0925 commented Mar 4, 2026

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0db17ac692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread server/src/services/k8s/provider_factory.py
Comment thread server/src/config.py
Pangjiping
Pangjiping previously approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Pangjiping Pangjiping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pangjiping Pangjiping added documentation Improvements or additions to documentation feature New feature or request component/server labels Mar 5, 2026
@Pangjiping Pangjiping mentioned this pull request Mar 5, 2026
Closed
Spground
Spground approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Spground Spground left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spground Spground merged commit 9c661b0 into alibaba:main Mar 5, 2026
24 of 27 checks passed
@fengcone fengcone mentioned this pull request Mar 5, 2026
Closed
axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes
Copy link
Copy Markdown

@axistore80-coder axistore80-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes
Copy link
Copy Markdown

@axistore80-coder axistore80-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀💥

@axistore80-coder
Copy link
Copy Markdown

axistore80-coder commented Mar 8, 2026

🚀

axistore80-coder
axistore80-coder approved these changes Mar 8, 2026
View reviewed changes
Copy link
Copy Markdown

@axistore80-coder axistore80-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥🚀

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes
Copy link
Copy Markdown

@axistore80-coder axistore80-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pllana95
pllana95 reviewed Mar 22, 2026
View reviewed changes
Copy link
Copy Markdown

@pllana95 pllana95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hittyt hittyt hittyt left review comments

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@Spground Spground Spground approved these changes

@Pangjiping Pangjiping Pangjiping approved these changes

@Generalwin Generalwin Awaiting requested review from Generalwin Generalwin is a code owner

@kevinlynx kevinlynx Awaiting requested review from kevinlynx kevinlynx is a code owner

@jwx0925 jwx0925 Awaiting requested review from jwx0925 jwx0925 is a code owner

@ninan-nn ninan-nn Awaiting requested review from ninan-nn ninan-nn is a code owner

+2 more reviewers

@pllana95 pllana95 pllana95 left review comments

@axistore80-coder axistore80-coder axistore80-coder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/server documentation Improvements or additions to documentation feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fengcone @jwx0925 @axistore80-coder @hittyt @Spground @Pangjiping @pllana95