Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

Performance issue when handling strings#1983

Merged
wenshao merged 1 commit intoalibaba:masterfrom
FlXME:patch-1
Jul 30, 2018
Merged

Performance issue when handling strings#1983
wenshao merged 1 commit intoalibaba:masterfrom
FlXME:patch-1

Conversation

@FlXME
Copy link
Copy Markdown
Contributor

@FlXME FlXME commented Jul 30, 2018

Improve performance by using StringBuilder instead of StringBuffer.

Improve performance by using StringBuilder instead of StringBuffer.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 30, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1983 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1983      +/-   ##
===========================================
- Coverage     81.02%     81%   -0.02%     
+ Complexity     6220    6218       -2     
===========================================
  Files           137     137              
  Lines         23130   23130              
  Branches       5356    5356              
===========================================
- Hits          18740   18737       -3     
- Misses         3039    3042       +3     
  Partials       1351    1351
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/alibaba/fastjson/asm/Type.java 77.41% <0%> (ø) 34 <0> (ø) ⬇️
...com/alibaba/fastjson/parser/JSONReaderScanner.java 72.61% <0%> (-1.28%) 44% <0%> (-1%)
...ava/com/alibaba/fastjson/parser/JSONLexerBase.java 71.82% <0%> (-0.04%) 787% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42252b9...cd96bfb. Read the comment docs.

@wenshao wenshao merged commit 338183b into alibaba:master Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants