This repository was archived by the owner on Oct 23, 2024. It is now read-only.
Fixing flaky test JSONSerializerTest2.test_0#2133
Merged
wenshao merged 2 commits intoalibaba:masterfrom Nov 16, 2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_0 in JSONSerializerTest2 has a test-order dependency and it fails when it is run after JSONSerializerTest2.test_3.
test_0 can be fixed by clearing the serializers. The fix will enable test_0 to now pass in any test run order. Without the fix, the tests will get the following error. Let me know if you want to discuss more.