Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

Fixing flaky test JSONSerializerTest2.test_0#2133

Merged
wenshao merged 2 commits intoalibaba:masterfrom
OrDTesters:JSONSerializerTest2Fix
Nov 16, 2018
Merged

Fixing flaky test JSONSerializerTest2.test_0#2133
wenshao merged 2 commits intoalibaba:masterfrom
OrDTesters:JSONSerializerTest2Fix

Conversation

@OrDTesters
Copy link
Copy Markdown
Contributor

test_0 in JSONSerializerTest2 has a test-order dependency and it fails when it is run after JSONSerializerTest2.test_3.

test_0 can be fixed by clearing the serializers. The fix will enable test_0 to now pass in any test run order. Without the fix, the tests will get the following error. Let me know if you want to discuss more.

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at com.alibaba.json.bvt.serializer.JSONSerializerTest2.test_0(JSONSerializerTest2.java:24)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 12, 2018

CLA assistant check
All committers have signed the CLA.

@wenshao wenshao merged commit 22a13a9 into alibaba:master Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants