remove debug log statement in EXECUTOR shutdown callback#72
Merged
yndu13 merged 1 commit intoaliyun:masterfrom Nov 29, 2025
Merged
remove debug log statement in EXECUTOR shutdown callback#72yndu13 merged 1 commit intoaliyun:masterfrom
yndu13 merged 1 commit intoaliyun:masterfrom
Conversation
Using the signals module the library tries to gracefully shutdown the ThreadPoolExecutor with a callback. For us this causes some issues with the logger module warning that you're writing to write to a log file after the file is closed. With these signal callbacks you can't control the shutdown order.
Contributor
Author
|
I also think this aligns with the feedback in #67 |
yndu13
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the signals module the library tries to gracefully shutdown the ThreadPoolExecutor with a callback.
For us this causes some issues with the logger module warning that you're writing to write to a log file after the file is closed. With these signal callbacks you can't control the shutdown order.