Skip to content

feat: update hostname verifier #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacksonTian merged 1 commit into from
Mar 22, 2024
Merged

feat: update hostname verifier #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/com/aliyun/tea/okhttp/OkHttpClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,7 @@ public OkHttpClientBuilder certificate(Map<String, Object> map) {
sslContext.init(keyManagerFactory != null ? keyManagerFactory.getKeyManagers() : null
, trustManagerFactory.getTrustManagers()
, new SecureRandom());
this.builder.sslSocketFactory(sslContext.getSocketFactory(), trustManager).
hostnameVerifier(new TrueHostnameVerifier());
this.builder.sslSocketFactory(sslContext.getSocketFactory(), trustManager);
}
return this;
} catch (Exception e) {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/aliyun/tea/okhttp/OkHttpClientBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public void certificateTest() throws IOException {
OkHttpClientBuilder builder = new OkHttpClientBuilder().certificate(map);

OkHttpClient client = builder.buildOkHttpClient();
Assert.assertTrue(client.hostnameVerifier() instanceof TrueHostnameVerifier);
Assert.assertFalse(client.hostnameVerifier() instanceof TrueHostnameVerifier);
Assert.assertNotNull(client.sslSocketFactory());

map.put("key", null);
Expand Down