feat: optimize SSLSocketFactory implementation#223
Merged
Conversation
JacksonTian
reviewed
Aug 16, 2024
| trustManager.checkServerTrusted(chain, authType); | ||
| return; // someone trusts them. success! | ||
| } catch (CertificateException e) { | ||
| // maybe someone else will trust them |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
噢噢不是，这里是个链式检查，检查到最后一个还是不trust的话，会抛出CertificateException("None of the TrustManagers trust this certificate chain")
yndu13
force-pushed
the
sslSocketFactory
branch
from
56105ca to
40820cf
Compare
JacksonTian
approved these changes
Aug 19, 2024
| trustManager.checkServerTrusted(chain, authType); | ||
| return; // someone trusts them. success! | ||
| } catch (CertificateException e) { | ||
| // maybe someone else will trust them |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.