Open
Conversation
alja
reviewed
Feb 4, 2026
alja
reviewed
Feb 4, 2026
| REveTrans fCamBase; // Base camera matrix (main positioning) | ||
| REveTrans fCamTrans; | ||
|
|
||
| // Original direction vectors (for Setup) |
Owner
There was a problem hiding this comment.
Remove commented lines with V1, V2.
The camBase matrix is holding this info.
Lines 65-69 can also be removed.
alja
reviewed
Feb 4, 2026
| #include <ROOT/REveSystem.hxx> | ||
| #include <ROOT/RLogger.hxx> | ||
|
|
||
| #include <ROOT/REveCamera.hxx> |
Owner
There was a problem hiding this comment.
A better practice is to include the REveCamera.hxx header in REveManager.cxx.
alja
reviewed
Feb 4, 2026
|
|
||
| REveViewerList *fViewers{nullptr}; | ||
| REveSceneList *fScenes{nullptr}; | ||
| REveElement *fCameras{nullptr}; // yuxiao |
Owner
There was a problem hiding this comment.
fCamera declaration does not need a comment.
alja
reviewed
Feb 4, 2026
| // void SetCameraType(ECameraType t); | ||
| // ECameraType GetCameraType() const { return fCamera->GetType(); } | ||
| void SetCamera(::ROOT::Experimental::REveCamera *cam); | ||
| ElementId_t GetCameraId() const { return fCameraId; } // yuxiao |
Owner
There was a problem hiding this comment.
Perhaps GetCameraId() can be replaced with:
REveCamera* GetCamera() {return fCamera; }
Just for the Get/Set symetry.
ElementId_t fCameraId member is not needed. One can get the if with fCamera->GetElementId()
alja
reviewed
Feb 4, 2026
|
|
||
| fScenes = new REveSceneList("Scenes"); | ||
| fScenes->IncDenyDestroy(); | ||
| fScenes->IncDenyDestroy(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #