Merged
Conversation
|
Oh wow! I was so excited to get this review since I'm kind of a nerd for front-end and design. :) Plus I wanted to do this project at some point. My thoughts: I like the choice of Open Sans Condensed from Google Fonts. A suggestion would be to revert to the regular Open Sans with the tags that are smaller than h4 for readability and accessibility. Your color theme is a nice choice that could be adapted to be darker or lighter, depending on the project's needs. Re: the background image that you used, the wood panels. It's best practice to download the image and serve it to your page from your own files instead. Funny touch with all of the variants of lorem ipsum! You had cheese, wine, Lord of the Rings, hahaha. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.