Merged
Conversation
ian-deans
reviewed
Mar 13, 2017
ian-deans
left a comment
ian-deans
left a comment
There was a problem hiding this comment.
Looks great! The page looks good and the code is clean. I'm a little thrown off by the comments between some of spans but thats just me.
|
|
||
| <div class="flex-container sample-text"> | ||
| <p> | ||
| <address> |
There was a problem hiding this comment.
Nice! Never thought of creating my own tags for things.
| <span class="element-color"><address></span><br> | ||
| <span class="tab element-color"><strong></span><!-- | ||
| -->Learners Guild<!-- | ||
| --><span class="element-color"></strong><br></span><br> |
There was a problem hiding this comment.
Completely inconsequential, but the comments between spans are a bit baffling to me 0.o
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't add more block quotes, instead cleaned up CSS and HTML