Skip to content

fleshing out addresses section in html and adding address in css #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allyface merged 1 commit into from
Mar 9, 2017
Merged

fleshing out addresses section in html and adding address in css #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 72 additions & 15 deletions demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ <h1 class="section-title">Headings</h1>
<p>To style headings in various sizes, add the
<code class="class-name">.headings</code> class to your
<code class="element-in-text">&lt;h1&gt;</code> through
<code class="element-in-text">&lt;h6&gt;</code> tags.</p>
<code class="element-in-text">&lt;h6&gt;</code> tags.
</p>
</div>

<div class="sample-text">
Expand Down Expand Up @@ -91,13 +92,13 @@ <h6 class= "headings">h6. Vast Quoll <small>Secondary text</small></h6>
<h1 class="section-title">Body copy</h1>

<div class="breakdown">
<p>Vast CSS global default <!--
--><code class="element-in-text">font-size</code> is <!--
--><b>13px</b>, with a <!--
--><code class="element-in-text">line-height</code> of<!--
--><b> 1.5</b>. This is applied to the <!--
--><code class="element-in-text">&lt;body&gt;</code> and all paragraphs. Including, <!--
--><code class="element-in-text">&lt;p&gt;</code> (paragraphs) receive a bottom margin of 10px.
<p>Vast CSS global default
<code class="element-in-text">font-size</code> is
<b>13px</b>, with a
<code class="element-in-text">line-height</code> of
<b> 1.5</b>. This is applied to the
<code class="element-in-text">&lt;body&gt;</code> and all paragraphs. Including,
<code class="element-in-text">&lt;p&gt;</code> (paragraphs) receive a bottom margin of 10px.
</p>
</div>

Expand Down Expand Up @@ -128,14 +129,70 @@ <h2 class = "section-title">Lead body copy</h2>
</div>

<div class="sample-code">
<p>
<span class="element-color">&lt;p</span>
<span class="class">class=</span><!--
--><span class="class-name">"lead"</span><!--
<code>
<p>
<span class="element-color">&lt;p</span>
<span class="class">class=</span><!--
--><span class="class-name">"lead"</span><!--
--><span class="element-color">&gt;</span><!--
-->...<!--
--><span class="element-color">&lt;/p&gt;</span>
</p>
</code>
</div>
</header>

<header id="address">
<h1 class="section-title">Addresses</h1>

<div class="breakdown">
<p>Present contact information in our default style by using the <code class="element-in-text">&lt;address&gt;</code> tag. Preserve your formatting by ending all lines with <code class="element-in-text">&lt;br&gt;</code>.</p>
</div>

<div class="sample-text">
<address>
<strong>Learners Guild</strong><br>
492 Ninth Street (Garden Level)<br>
Oakland, CA 94607<br>
<abbr title="Phone">P:</abbr> (123) 456-7890
</address>

<address>
<strong>Full Name</strong><br>
<a href="mailto:#">first.last@example.com</a>
</address>
</div>

<div class="sample-code">
<code>
<span class="element-color">&lt;address&gt;</span><br>
<span class="tab element-color">&lt;strong&gt;</span><!--
-->Learners Guild<!--
Copy link

@breyana breyana Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there <!-- --> tags throughout the code?

Copy link
Owner Author

@allyface allyface Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inline text and the spans create extra spaces we don't want, the comments around the line breaks in our code get rid of those spaces.

--><span class="element-color">&lt;/strong&gt;&lt;br&gt;</span><br>
<span class="tab">492 Ninth Street (Garden Level)</span><!--
--><span class="element-color">&lt;br&gt;</span><br>
<span class="tab">Oakland, CA 94607</span><!--
--><span class="element-color">&lt;br&gt;</span><br>
<span class="tab element-color">&lt;abbr</span>
<span class="class">title=</span><!--
--><span class="class-name">"Phone"</span><!--
--><span class="element-color">&gt;</span><!--
-->...<!--
--><span class="element-color">&lt;/p&gt;</span>
</p>
-->P:<!--
--><span class="element-color">&lt;/abbr&gt;</span>
(123) 456-7890<br>
<span class="element-color">&lt;/address&gt;</span><br><br>
<span class="element-color">&lt;address&gt;</span><br>
<span class="tab element-color">&lt;strong&gt;</span><!--
-->Full Name<!--
--><span class="element-color">&lt;/strong&gt;&lt;br&gt;</span><br>
<span class="tab element-color">&lt;a</span>
<span class="class">href=</span><!--
--><span class="class-name">"mailto:#"</span><!--
--><span class="element-color">&gt;</span><!--
-->first.last@example.com<!--
--><span class="element-color">&lt;/a&gt;</span><br>
<span class="element-color">&lt;/address&gt;</span>
</code>
</div>
</header>
</body>
Expand Down
12 changes: 12 additions & 0 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ p {
margin-bottom: 10px;
}

address {
font-size: 14px;
line-height: 1.5;
margin-bottom: 7px;
font-style: normal;
font-family: sans-serif;
}

.section-title {
color: blue;
background-color: #d6e2ed;
Expand Down Expand Up @@ -36,3 +44,7 @@ p {
font-size: 16px;
font-weight: lighter;
}

.tab {
margin-left: 40px;
}