Fix source port resolution in CWL translator#1048
Draft
LanderOtto wants to merge 1 commit into
Draft
Conversation
79ee3f1 to
ef934c1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1048 +/- ##
==========================================
+ Coverage 74.99% 75.01% +0.02%
==========================================
Files 89 89
Lines 12305 12305
Branches 2150 2150
==========================================
+ Hits 9228 9231 +3
+ Misses 2550 2549 -1
+ Partials 527 525 -2 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Test added in common-workflow-language/cwl-v1.3/pull/98 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where a CWL workflow defines an input and an output with the same name. Before this commit, the StreamFlow translator created a malformed workflow, leading to a deadlock or erroneous execution.
The fix leverages the StreamFlow approach for translating inner objects to outer objects. When a step requires a source port and it is a port of another step, the port is already attached to the step. If the port is not an output of a step, it means the port is the output of the workflow