Skip to content

Fix source port resolution in CWL translator#1048

Draft
LanderOtto wants to merge 1 commit into
masterfrom
fix/source-port-ret
Draft

Fix source port resolution in CWL translator#1048
LanderOtto wants to merge 1 commit into
masterfrom
fix/source-port-ret

Conversation

@LanderOtto
Copy link
Copy Markdown
Collaborator

@LanderOtto LanderOtto commented Apr 28, 2026

This commit fixes an issue where a CWL workflow defines an input and an output with the same name. Before this commit, the StreamFlow translator created a malformed workflow, leading to a deadlock or erroneous execution.

The fix leverages the StreamFlow approach for translating inner objects to outer objects. When a step requires a source port and it is a port of another step, the port is already attached to the step. If the port is not an output of a step, it means the port is the output of the workflow

@LanderOtto LanderOtto force-pushed the fix/source-port-ret branch from 79ee3f1 to ef934c1 Compare April 28, 2026 15:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.01%. Comparing base (99dd235) to head (ef934c1).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
+ Coverage   74.99%   75.01%   +0.02%     
==========================================
  Files          89       89              
  Lines       12305    12305              
  Branches     2150     2150              
==========================================
+ Hits         9228     9231       +3     
+ Misses       2550     2549       -1     
+ Partials      527      525       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LanderOtto
Copy link
Copy Markdown
Collaborator Author

Test added in common-workflow-language/cwl-v1.3/pull/98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant