alsaloop: Fix the silence generation in xrun_sync #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The silence frames generation in xrun_sync() seems to be currently a bit off as snd_pcm_format_set_silence() uses a wrong buffer address and size for zero-ing out the data. Consequently instead of clearing out the last frame(s), snd_pcm_format_set_silence() ends up silencing samples somewhere else in the buffer. This is partilarly more obvious for higher frame sizes (e.g. more than 2 channels). This patch fixes this issue by correcting the parameters passed to snd_pcm_format_set_silence(). Signed-off-by: Dragos Tarcatu <dragos_tarcatu@mentor.com>
dragosht
force-pushed
the
alsaloop-silence-fix
branch
from
e25ee9c to
d7c9f78
Compare
perexg
pushed a commit
that referenced
this pull request
Sep 25, 2020
The silence frames generation in xrun_sync() seems to be currently a bit off as snd_pcm_format_set_silence() uses a wrong buffer address and size for zero-ing out the data. Consequently instead of clearing out the last frame(s), snd_pcm_format_set_silence() ends up silencing samples somewhere else in the buffer. This is partilarly more obvious for higher frame sizes (e.g. more than 2 channels). This patch fixes this issue by correcting the parameters passed to snd_pcm_format_set_silence(). BugLink: #58 Signed-off-by: Dragos Tarcatu <dragos_tarcatu@mentor.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
perexg
pushed a commit
that referenced
this pull request
Sep 25, 2020
The silence frames generation in xrun_sync() seems to be currently a bit off as snd_pcm_format_set_silence() uses a wrong buffer address and size for zero-ing out the data. Consequently instead of clearing out the last frame(s), snd_pcm_format_set_silence() ends up silencing samples somewhere else in the buffer. This is partilarly more obvious for higher frame sizes (e.g. more than 2 channels). This patch fixes this issue by correcting the parameters passed to snd_pcm_format_set_silence(). BugLink: #58 Signed-off-by: Dragos Tarcatu <dragos_tarcatu@mentor.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Member
|
Thanks, merged in 8572c0c . |
dragosht
pushed a commit
to dragosht/alsa-utils
that referenced
this pull request
Sep 30, 2020
The silence frames generation in xrun_sync() seems to be currently a bit off as snd_pcm_format_set_silence() uses a wrong buffer address and size for zero-ing out the data. Consequently instead of clearing out the last frame(s), snd_pcm_format_set_silence() ends up silencing samples somewhere else in the buffer. This is partilarly more obvious for higher frame sizes (e.g. more than 2 channels). This patch fixes this issue by correcting the parameters passed to snd_pcm_format_set_silence(). BugLink: alsa-project#58 Signed-off-by: Dragos Tarcatu <dragos_tarcatu@mentor.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
lgirdwood
pushed a commit
to thesofproject/alsa-utils
that referenced
this pull request
Dec 3, 2020
The silence frames generation in xrun_sync() seems to be currently a bit off as snd_pcm_format_set_silence() uses a wrong buffer address and size for zero-ing out the data. Consequently instead of clearing out the last frame(s), snd_pcm_format_set_silence() ends up silencing samples somewhere else in the buffer. This is partilarly more obvious for higher frame sizes (e.g. more than 2 channels). This patch fixes this issue by correcting the parameters passed to snd_pcm_format_set_silence(). BugLink: alsa-project#58 Signed-off-by: Dragos Tarcatu <dragos_tarcatu@mentor.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The silence frames generation in xrun_sync() seems to be currently
a bit off as snd_pcm_format_set_silence() uses a wrong buffer address
and size for zero-ing out the data. Consequently instead of clearing
out the last frame(s), snd_pcm_format_set_silence() ends up silencing
samples somewhere else in the buffer. This is partilarly more obvious
for higher frame size (e.g. when using more than 2 channels).
This patch fixes this issue by correcting the parameters passed to
snd_pcm_format_set_silence().
Signed-off-by: Dragos Tarcatu dragos_tarcatu@mentor.com