Skip to content

Feat/transaction codes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alt-ctrl-dev merged 3 commits into from
Apr 1, 2023
Merged

Feat/transaction codes #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0670905
refactor: returning error for incorrect code
alt-ctrl-dev Apr 1, 2023
5c55616
fix: updated doctest
alt-ctrl-dev Apr 1, 2023
16108be
docs: updated description
alt-ctrl-dev Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/aba_file_validator.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ defmodule AbaFileValidator do
"""

@doc """
Hello world.
Get a description for a given transaction code

## Examples

iex> AbaFileValidator.get_transaction_code_description("11")
:not_provided
:error

iex> AbaFileValidator.get_transaction_code_description(13)
"Externally initiated debit items"
Expand All @@ -33,5 +33,5 @@ defmodule AbaFileValidator do
def get_transaction_code_description("56"), do: "Dividend"
def get_transaction_code_description(57), do: "Debenture/Note Interest"
def get_transaction_code_description("57"), do: "Debenture/Note Interest"
def get_transaction_code_description(_), do: :not_provided
def get_transaction_code_description(_), do: :error
end
2 changes: 1 addition & 1 deletion test/aba_file_validator_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ defmodule AbaFileValidatorTest do
doctest AbaFileValidator

test "transaction code description" do
assert AbaFileValidator.get_transaction_code_description(11) == :not_provided
assert AbaFileValidator.get_transaction_code_description(11) == :error
assert AbaFileValidator.get_transaction_code_description(13) == "Externally initiated debit items"
assert AbaFileValidator.get_transaction_code_description("13") == "Externally initiated debit items"
assert AbaFileValidator.get_transaction_code_description(50) == "Externally initiated credit items with the exception of those bearing Transaction Codes"
Expand Down