Skip to content

addToLibrarySearchPath breaks when value is not an array #94

@grabbou

Description

@grabbou

https://github.com/alunny/node-xcode/blob/master/lib/pbxProject.js#L1146. On this line we only check if value is $(inherited) and convert it to an array otherwise. I've seen projects that have other, non $(inherited) single value there, which causes the script to break with .push is undefined since the value will be a string.

I think we could just replace that check with !Array.isArray() which should make it more future proof.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions