Conversation
- Fix FFI_TableProvider::new() → new_with_ffi_codec(): DataFusion 52 changed the table provider FFI signature to require a LogicalExtensionCodec. The SessionContext now passes itself as a `session` arg to __datafusion_table_provider__; we extract the codec via __datafusion_logical_extension_codec__() following the official datafusion-python v52 FFI example. - Add ffi_logical_codec_from_pycapsule() helper (mirrors examples/datafusion-ffi-example/src/utils.rs). - Remove FFI workaround notes and TODO(#107): the collect() bug in DataFusion v51 is fixed in v52. Update test_aggregation_with_many_batches to use collect() directly to verify correctness of parallel aggregation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107.