Conversation
…le with `uv build`.
…e duplicate logic.
…some refactoring.
…ll investigate later.
…r, with unit tests.
alxmrs
commented
Jul 17, 2025
…to corrent column names as well as correct scanning (type handing).
alxmrs
changed the title
… to make sure they're properly testing the bindings.
alxmrs
commented
Jul 30, 2025
Owner
Author
alxmrs
left a comment
alxmrs
left a comment
There was a problem hiding this comment.
First part of a self-code review (for the benefit of Claude). Will resume tomorrow.
src/table_provider.rs
Outdated
Comment on lines
+763
to
+777
| DataType::Int64 => { | ||
| Arc::new(Int64Array::new_null(0)) as Arc<dyn arrow_array::Array> | ||
| } | ||
| DataType::Float64 => { | ||
| Arc::new(Float64Array::new_null(0)) as Arc<dyn arrow_array::Array> | ||
| } | ||
| DataType::Int32 => { | ||
| Arc::new(Int32Array::new_null(0)) as Arc<dyn arrow_array::Array> | ||
| } | ||
| DataType::Float32 => { | ||
| Arc::new(Float32Array::new_null(0)) as Arc<dyn arrow_array::Array> | ||
| } | ||
| DataType::Utf8 => Arc::new(arrow_array::StringArray::new_null(0)) | ||
| as Arc<dyn arrow_array::Array>, | ||
| _ => Arc::new(Int64Array::new_null(0)) as Arc<dyn arrow_array::Array>, // Default fallback |
Owner
Author
There was a problem hiding this comment.
I think there are missing data types here.
This was referenced Sep 26, 2025
Owner
Author
|
This is better implemented in arrow-zarr or simply #100. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of #4. Rust sources were mostly generated by Claude Code.