Simplify ion-java-cli OutputFormat#1014
Merged
jobarr-amzn merged 3 commits intoion-11-encodingfrom Dec 12, 2024
Merged
Conversation
zslayton
approved these changes
Dec 12, 2024
| } else if (builder instanceof IonBinaryWriterBuilder) { | ||
| return ((IonBinaryWriterBuilder)builder).withImports(symbolTable).build(out); | ||
| } else { | ||
| throw new IllegalStateException("This is impossible, none of the enums can do this"); |
Contributor
There was a problem hiding this comment.
I think this text could be more descriptive.
tgregg
approved these changes
Dec 12, 2024
tgregg
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Simplify ion-java-cli OutputFormat * Clarify unreachable statement message * Private static factories instead of functions
popematt
pushed a commit
to popematt/ion-java
that referenced
this pull request
Sep 25, 2025
* Simplify ion-java-cli OutputFormat * Clarify unreachable statement message * Private static factories instead of functions
popematt
pushed a commit
that referenced
this pull request
Sep 25, 2025
* Simplify ion-java-cli OutputFormat * Clarify unreachable statement message * Private static factories instead of functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.