Skip to content

Specify that OversizedSymbolTableHandler is required for limited buffers #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austnwil merged 2 commits into from
Oct 1, 2025
+14 −1
Merged

Specify that OversizedSymbolTableHandler is required for limited buffers #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37956ca
Specify that OversizedSymbolTableHandler is required for limited buffers
austnwil Sep 30, 2025
be4714f
Avoid catch-and-rethrow for missing OversizedValueHandler errors
austnwil Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/amazon/ion/BufferConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ protected BufferConfiguration(Builder<Configuration, ?> builder) {
/**
* Requires that the maximum buffer size not be limited.
*/
protected void requireMaximumBufferSize() {
private void requireMaximumBufferSize() {
if (maximumBufferSize < _Private_IonConstants.ARRAY_MAXIMUM_SIZE) {
throw new IllegalArgumentException(
"Must specify an OversizedValueHandler when a custom maximum buffer size is specified."
Expand Down
13 changes: 13 additions & 0 deletions src/main/java/com/amazon/ion/IonBufferConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

package com.amazon.ion;

import com.amazon.ion.impl._Private_IonConstants;

/**
* Configures buffers that hold Ion data.
*/
Expand Down Expand Up @@ -185,6 +187,17 @@ private IonBufferConfiguration(Builder builder) {
}
}

/**
* Requires that the maximum buffer size not be limited.
*/
private void requireMaximumBufferSize() {
if (getMaximumBufferSize() < _Private_IonConstants.ARRAY_MAXIMUM_SIZE) {
throw new IllegalArgumentException(
"Must specify both an OversizedValueHandler and OversizedSymbolTableHandler when a custom maximum buffer size is specified."
);
}
}

/**
* @return the handler that will be notified when oversized symbol tables are encountered.
*/
Expand Down
Loading