Adds IonRawBinaryWriter_1_1#1133
Merged
popematt merged 6 commits intoamazon-ion:ion11from Oct 30, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ion11 #1133 +/- ##
========================================
Coverage ? 68.97%
Complexity ? 6172
========================================
Files ? 200
Lines ? 25079
Branches ? 4385
========================================
Hits ? 17299
Misses ? 6442
Partials ? 1338 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tgregg
reviewed
Oct 28, 2025
src/test/java/com/amazon/ion/impl/bin/IonManagedBinaryWriterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/ion/impl/bin/TimestampEncoder_1_1Test.kt
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/ion/impl/bin/TimestampEncoder_1_1Test.kt
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/ion/impl/bin/IonRawBinaryWriter_1_1.kt
Outdated
Show resolved
Hide resolved
| override fun stepInTaglessElementSExp(macroId: Int, macroName: String?) { | ||
| currentContainer = containerStack.push { it.reset(TE_SEXP, buffer.position()) } | ||
| buffer.writeByte(OpCode.TAGLESS_ELEMENT_SEXP) | ||
| currentContainer.metadataOffset += writeEExpMacroIdWithoutLengthPrefix(macroId) |
Contributor
There was a problem hiding this comment.
Do we need a variant that allows the macro shapes to be length-prefixed? (We have an example of this in the spec)
src/main/java/com/amazon/ion/impl/bin/IonRawBinaryWriter_1_1.kt
Outdated
Show resolved
Hide resolved
tgregg
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
Changes are grouped into commits to make it easier to review them.
TimestampEncoder_1_1and testsIonRawBinaryWriter_1_1and testsIonEncoder_1_1and an obsolete version ofOpCodesand some unused constants.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.