Adds support for FixedInt and FixedUInt in WriteBuffer#610
Merged
popematt merged 2 commits intoamazon-ion:masterfrom Oct 16, 2023
Merged
Adds support for FixedInt and FixedUInt in WriteBuffer#610popematt merged 2 commits intoamazon-ion:masterfrom
popematt merged 2 commits intoamazon-ion:masterfrom
Conversation
Codecov ReportAll modified lines are covered by tests ✅
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
tgregg
reviewed
Oct 17, 2023
Comment on lines
+1408
to
+1429
| writeByte((byte) value); | ||
| if (numBytes > 1) { | ||
| writeByte((byte) (value >> 8)); | ||
| if (numBytes > 2) { | ||
| writeByte((byte) (value >> 8 * 2)); | ||
| if (numBytes > 3) { | ||
| writeByte((byte) (value >> 8 * 3)); | ||
| if (numBytes > 4) { | ||
| writeByte((byte) (value >> 8 * 4)); | ||
| if (numBytes > 5) { | ||
| writeByte((byte) (value >> 8 * 5)); | ||
| if (numBytes > 6) { | ||
| writeByte((byte) (value >> 8 * 6)); | ||
| if (numBytes > 7) { | ||
| writeByte((byte) (value >> 8 * 7)); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
As an optimization, we could have fast/slow variants of this too, where we do the current technique when remaining() < numBytes, and otherwise we just write directly into the underlying array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
FixedIntandFixedUIntinWriteBufferBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.