Adds support for writing Ion 1.1 null, bool, int, and float binary encoding#612
Merged
popematt merged 2 commits intoamazon-ion:ion-11-encodingfrom Oct 25, 2023
Merged
Conversation
Codecov ReportAttention:
... and 27 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
tgregg
approved these changes
Oct 17, 2023
tgregg
pushed a commit
that referenced
this pull request
Nov 14, 2023
popematt
added a commit
that referenced
this pull request
Nov 16, 2023
This was referenced Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
WriteBufferto writeFlexInts andFlexUInts fromBigIntegersOpCodes, a class that holds op code constantsIonEncoding_1_1, a class that may later be subsumed by a Raw Binary Writer for Ion 1.1. This class contains methods that can write raw Ion values to aWriteBuffer.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.