Fixes a bug that allowed NegativeArraySizeException to be thrown from IonReader.newBytes().#705
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
============================================
+ Coverage 67.23% 67.24% +0.01%
- Complexity 5484 5486 +2
============================================
Files 159 159
Lines 23025 23027 +2
Branches 4126 4126
============================================
+ Hits 15481 15485 +4
Misses 6262 6262
+ Partials 1282 1280 -2 ☔ View full report in Codecov by Sentry. |
zslayton
approved these changes
Jan 29, 2024
jobarr-amzn
approved these changes
Jan 29, 2024
… IonReader.newBytes().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
FasterXML/jackson-dataformats-binary#469
Description of changes:
A value's end index is calculated by adding the reader's current index in the buffer (
peekIndex) to the value's declared length. Before this fix, the validation for a too-large end index (endIndex < 0) happened too early (beforepeekIndexhad been added). This allowed for the possibility that a very large but valid value length could overflow whenpeekIndexwas added, as exercised by the added test. When this happened for blob/clob values,IonReader.byteSize()would return a negative number, causingNegativeArraySizeExceptionto be thrown fromIonReader.newBytes(). After the fix, the reader throwsIonExceptionupon encountering the overflowing end index.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.