Ensures that the cursor's value marker is fully reset between values.#787
Merged
Ensures that the cursor's value marker is fully reset between values.#787
Conversation
popematt
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fuzzing identified a case where this mattered. This is now captured in the added unit test. In summary, if the previous value was a struct, and the current value begins with an incomplete annotation wrapper, the reader would attempt to read additional bytes from the input to determine if the value was a symbol table. This could result in
ArrayIndexOutOfBoundsException, as in this case, if those bytes are not available. Clearing the typeId between values ensures that the reader will never enter the symbol table determination logic when positioned on an incomplete annotation wrapper, allowing that logic to remain unchanged. After this fix, anIonExceptionfor unexpected EOF is thrown in this case.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.