Adds check for license headers and unused imports#789
Merged
popematt merged 1 commit intoamazon-ion:masterfrom Apr 12, 2024
Merged
Adds check for license headers and unused imports#789popematt merged 1 commit intoamazon-ion:masterfrom
popematt merged 1 commit intoamazon-ion:masterfrom
Conversation
d5a90fc to
d396c2c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #789 +/- ##
============================================
+ Coverage 67.23% 67.35% +0.12%
- Complexity 5484 5506 +22
============================================
Files 159 160 +1
Lines 23025 23067 +42
Branches 4126 4123 -3
============================================
+ Hits 15481 15537 +56
+ Misses 6262 6256 -6
+ Partials 1282 1274 -8 ☔ View full report in Codecov by Sentry. |
b1e8f6f to
65a63c4
Compare
tgregg
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
I noticed recently that some of our files are lacking a license header. I've added the
spotlessplugin to ensure that we have a license header on all new java and kotlin files going forward. I also included a check for unused imports in java, but that might be redundant withspotbugs. In kotlin, it's already checked byktlint.If you happen to forget to add license headers, you can have this tool add them automatically by running
./gradlew spotlessApply.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.