Change IonSystemBuilder's default charset to UTF-8#802
Merged
popematt merged 1 commit intoamazon-ion:masterfrom Apr 23, 2024
Merged
Change IonSystemBuilder's default charset to UTF-8#802popematt merged 1 commit intoamazon-ion:masterfrom
IonSystemBuilder's default charset to UTF-8#802popematt merged 1 commit intoamazon-ion:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #802 +/- ##
============================================
+ Coverage 67.23% 67.41% +0.17%
- Complexity 5484 5518 +34
============================================
Files 159 160 +1
Lines 23025 23077 +52
Branches 4126 4126
============================================
+ Hits 15481 15557 +76
+ Misses 6262 6246 -16
+ Partials 1282 1274 -8 ☔ View full report in Codecov by Sentry. |
tgregg
reviewed
Apr 22, 2024
Contributor
tgregg
left a comment
There was a problem hiding this comment.
Will approve as long as a dry run looks good
tgregg
approved these changes
Apr 23, 2024
tgregg
pushed a commit
that referenced
this pull request
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fix #783
Description of changes:
IonSystemBuildertoUTF-8IonSystemdoes interact with the catalog outside of the reader/writer builders throughcreateSharedSymbolTable(). I don't think there's a good way to define how that method should interact with multiple catalogs since a shared symbol table could be present in one catalog but not in another.IonSystemLiteare all non-functional. I cleaned up some formatting near the reader/wwriter builder member fields (and updated the copyright header).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.