Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
============================================
+ Coverage 67.23% 67.68% +0.44%
- Complexity 5484 5525 +41
============================================
Files 159 159
Lines 23025 22982 -43
Branches 4126 4108 -18
============================================
+ Hits 15481 15555 +74
+ Misses 6262 6155 -107
+ Partials 1282 1272 -10 ☔ View full report in Codecov by Sentry. |
tgregg
reviewed
May 20, 2024
Contributor
tgregg
left a comment
tgregg
left a comment
There was a problem hiding this comment.
Thanks, again, for the cleanups! I've left comments on three files that we should leave unchanged in order to avoid merge conflicts with the ion-11-encoding branch. All others look good.
Contributor
There was a problem hiding this comment.
Please leave this one unchanged.
Contributor
There was a problem hiding this comment.
Please leave this one unchanged.
src/main/java/com/amazon/ion/impl/IonReaderContinuableApplicationBinary.java
Show resolved
Hide resolved
linlin-s
pushed a commit
that referenced
this pull request
Jul 3, 2024
* unused code removal * avoid ion-11-encoding merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.