Adds checks for timestamp values with length 0.#921
Merged
Conversation
tgregg
force-pushed
the
check-timestamp-length-0
branch
from
c84e40a to
6ebfc83
Compare
jobarr-amzn
approved these changes
Aug 6, 2024
tgregg
force-pushed
the
check-timestamp-length-0
branch
from
6ebfc83 to
44a025e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
According to the Ion spec, timestamp values cannot have length 0. This change allows for cleaner failure (via
IonException) when this is violated.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.