Packaging, CI, and miscellaneous fixes #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 1, 2024 16:07
When we're performing a refresh, IMDS has had time to stabilize. We can skip most of our retries and abort if IMDS is missing something that should be there. Anything we missed will be picked up by the next trigged execution.
If we're refreshing an interface's config but the corresponding sysfs node doesn't exist, exit immediately. It's likely that the device has been moved to another namespace or removed from the instance altogether. Similarly, don't wait for the interface to be online when refreshing the configuration.
added 3 commits
March 6, 2024 11:38
Ensure that our networkd configuration takes priority over what netplan installs.
Handle a rare IMDS failure mode in which the service returns a 0 value for both device-number and network-card for an interface that is not the primary ENI.
vigh-m
approved these changes
Mar 6, 2024
Contributor
vigh-m
left a comment
vigh-m
left a comment
There was a problem hiding this comment.
LGTM. As discussed, we're not too concerned about exiting in _get_network_card() and triggered the networkd reload trap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
Several small improvements:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.