ebsnvme-id: open devices in read-only mode #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Opening block devices in read/write mode triggers a kernel change event, which leads to the child devices (corresponding with the partitions) being deleted and recreated. Opening the fd in read-only mode still provides access to the NVME ioctl() interface, but avoids the unnecessary change event.
Issue #15
Tested on Debian unstable (kernel 5.15, python 3.9.9) and Amazon Linux 2 (kernel 4.14, python 2.7.18):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.