Repository maintenance #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 11, 2022 13:16
With GitHub's recent change to enforce stronger hash algorithms, Circle CI was unable to clone the project repository. By installing our dependencies earlier in the workflow, we are able to ensure that the AL2 git and ssh clients are used, which do support the newer algorithms. Details in this discussion on the Circle CI forums: https://discuss.circleci.com/t/discussion-and-resolution-for-error-youre-using-an-rsa-key-with-sha-1-which-is-no-longer-allowed/42572
Shellcheck reported a number of warnings about unquoted references. The specific issues were harmless given the context, but adding quotes helps with consistency. Additionally, shellcheck identified that the '-h' command line option was defined twice (for --local-hostname and --help). Drop one of these references.
halfdime-code
left a comment
halfdime-code
left a comment
There was a problem hiding this comment.
One small comment. Otherwise it looks good.
| -g | --tags ) print_tags | ||
| ;; | ||
| -h | --help ) print_help | ||
| --help ) print_help |
There was a problem hiding this comment.
I don't see a reason for removing -h functionality here for help.
Contributor
Author
There was a problem hiding this comment.
Because -h is already used for --local-hostname
halfdime-code
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR includes 3 commits:
ec2-metadataprogramThere are no functional changes here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.