Skip to content

fix: Only validate ambient-runner-secrets when Vertex AI is disabled #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sallyom merged 1 commit into from
Dec 4, 2025
Merged

fix: Only validate ambient-runner-secrets when Vertex AI is disabled #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions components/operator/internal/handlers/sessions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,21 +810,27 @@ func handleAgenticSessionEvent(obj *unstructured.Unstructured) error {
const runnerSecretsName = "ambient-runner-secrets" // ANTHROPIC_API_KEY only (ignored when Vertex enabled)
const integrationSecretsName = "ambient-non-vertex-integrations" // GIT_*, JIRA_*, custom keys (optional)

// Check if integration secrets exist (optional)
if _, err := config.K8sClient.CoreV1().Secrets(sessionNamespace).Get(context.TODO(), runnerSecretsName, v1.GetOptions{}); err != nil {
if !errors.IsNotFound(err) {
log.Printf("Error checking runner secret %s: %v", runnerSecretsName, err)
} else {
log.Printf("Runner secret %s missing in %s", runnerSecretsName, sessionNamespace)
// Only check for runner secrets when Vertex is disabled
// When Vertex is enabled, ambient-vertex secret is used instead
if !vertexEnabled {
if _, err := config.K8sClient.CoreV1().Secrets(sessionNamespace).Get(context.TODO(), runnerSecretsName, v1.GetOptions{}); err != nil {
if !errors.IsNotFound(err) {
log.Printf("Error checking runner secret %s: %v", runnerSecretsName, err)
} else {
log.Printf("Runner secret %s missing in %s (Vertex disabled)", runnerSecretsName, sessionNamespace)
}
statusPatch.AddCondition(conditionUpdate{
Type: conditionSecretsReady,
Status: "False",
Reason: "RunnerSecretMissing",
Message: fmt.Sprintf("Secret %s missing", runnerSecretsName),
})
_ = statusPatch.Apply()
return fmt.Errorf("runner secret %s missing in namespace %s", runnerSecretsName, sessionNamespace)
}
statusPatch.AddCondition(conditionUpdate{
Type: conditionSecretsReady,
Status: "False",
Reason: "RunnerSecretMissing",
Message: fmt.Sprintf("Secret %s missing", runnerSecretsName),
})
_ = statusPatch.Apply()
return fmt.Errorf("runner secret %s missing in namespace %s", runnerSecretsName, sessionNamespace)
log.Printf("Found runner secret %s in %s (Vertex disabled)", runnerSecretsName, sessionNamespace)
} else {
log.Printf("Vertex AI enabled, skipping runner secret %s validation", runnerSecretsName)
}

integrationSecretsExist := false
Expand Down
Loading