chore: update Kind node image from v1.28.0 to v1.35.0

[jeremyeder]

Summary

• Update Kind node image from kindest/node:v1.28.0 to v1.35.0 (Kind v0.31.0 default)
• Update minikube Kubernetes version from v1.28.3 to v1.35.0 for consistency
• Update outdated comment about Podman compatibility

Test Plan

• make kind-down (if existing cluster)
• make kind-up — cluster creates successfully with v1.35.0
• kubectl get nodes shows v1.35.0
• make test-e2e-local — e2e tests pass

🤖 Generated with Claude Code

[github-actions]

Claude Code Review

Summary

This PR updates the Kubernetes version for local development environments (Kind and minikube) from v1.28.0 (released ~2 years ago) to v1.35.0 (Kind v0.31.0 default). This is a straightforward infrastructure maintenance change with no code modifications.

Issues by Severity

🚫 Blocker Issues

None identified.

🔴 Critical Issues

None identified.

🟡 Major Issues

None identified.

🔵 Minor Issues

1. Missing SHA256 verification documentation

• Location: e2e/scripts/setup-kind.sh:66
• Issue: The SHA256 hash for the new image (@sha256:452d707...) is included but there's no inline comment documenting how to verify/generate this hash for future updates.
• Impact: Minor - Makes future version updates slightly harder to validate.
• Recommendation: Add a comment explaining where this hash comes from (e.g., # SHA from https://github.com/kubernetes-sigs/kind/releases/tag/v0.31.0).

2. No explicit test plan execution evidence

• Issue: The PR body includes an unchecked test plan, but no evidence that tests were run before submission.
• Impact: Minor - CI will catch issues, but manual verification is always better.
• Recommendation: Consider adding a comment with test results (or check the boxes if tests passed).

Positive Highlights

✅ Excellent version alignment: Both Kind (v1.35.0) and minikube (v1.35.0) now use the same Kubernetes version, reducing inconsistencies across dev environments.

✅ Clear commit message: The commit follows conventional commit format and includes Co-Authored-By attribution.

✅ Updated documentation: The echo statement accurately reflects the new version (line 80 of setup-kind.sh).

✅ Proper SHA pinning: Using SHA256 digest for the Kind image prevents supply chain attacks and ensures reproducibility.

✅ Minimal scope: Only touches infrastructure configuration, no code changes required.

Recommendations

1. High Priority - CI Verification: Let CI workflows complete before merging. Specifically:

   • .github/workflows/e2e.yml (E2E tests with kind cluster)
   • .github/workflows/test-local-dev.yml (Local dev validation)

2. Medium Priority - Document hash source: Add inline comment for future maintainers:

   # SHA from https://github.com/kubernetes-sigs/kind/releases/tag/v0.31.0
   image: kindest/node:v1.35.0@sha256:452d707...

3. Low Priority - Update CLAUDE.md if needed: If there are any Kubernetes version-specific notes in CLAUDE.md or docs/developer/local-development/kind.md, verify they're still accurate.

4. Future Consideration: Consider adding a GitHub Dependabot or Renovate config to automate Kind/minikube version updates in the future.

Architecture & Standards Compliance

✅ Follows project standards: No code changes, only infrastructure config updates.
✅ No security concerns: SHA256 pinning is a security best practice.
✅ No performance concerns: Infrastructure change only.
✅ No testing gaps: E2E workflow will validate the change automatically.

Conclusion

This is a clean, well-scoped infrastructure update. The changes are appropriate and follow best practices. Approved pending CI validation.

Once CI passes, this is safe to merge.

---

🤖 Review generated by Claude Code with loaded context:

• Backend Development Standards
• Frontend Development Standards
• Security Standards
• K8s Client Usage Patterns
• Error Handling Patterns
• React Query Usage Patterns

---

🔍 View AI decision process (logs available for 90 days)

📋 View memory system files loaded (click to expand)

What Amber Loaded for Code Review

Amber automatically loaded these repository standards from the memory system:

1. CLAUDE.md - Master project instructions, development standards
2. backend-development.md - Go backend, K8s integration patterns
3. frontend-development.md - NextJS, Shadcn UI, React Query patterns
4. security-standards.md - Auth, RBAC, token handling
5. k8s-client-usage.md - User token vs service account patterns
6. error-handling.md - Consistent error patterns
7. react-query-usage.md - Data fetching patterns

Impact: This review used your repository's specific code quality standards, security patterns, and best practices from the memory system (PRs #359, #360) - not just generic code review guidelines.