feat: scrolling astral map screen

[nanowuu]

About the PR

• Added a scrollable astral map list which can be searched by name or by mod ID (with @)
• Added a separate translation key for biomes and structures not being found

Why / Balance

Better for usability

Technical details

• Astral Map screen completely changed to use a scrollable and searchable list widget, no more IdentifierSwitcher
• Removed biome synchronisation (that data is already available on the client, maybe because of the F3 screen)
• Added CallbackCheckboxWidget which allows for a callback when the checkbox is checked

Media

Requirements

• [X ] I have read and am following the Pull Request and Changelog Guidelines.
• [ X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

No more IdentifierSwitcher or AstralMapBlock.biomeIds but they weren't used by anything else anyway

Changelog

[rapbattlegod32]

ill test now

[rapbattlegod32]

my intellij is bugging out i cant test
@Addi3 you're going to have to review instead

[addi3phone]

my intellij is bugging out i cant test @Addi3 you're going to have to review instead

Will be in like 1hr or smth cus I'm not on my pc rn

[Addi3]

LGTM. Tested in game, locates structures and biomes fine, no noticeable issues with the GUI either and scales well with game window

[drtheodor]

Wouldn't it be better if this was static? This way it doesn't have to re-think what the mods' names are. It could be lazily initialized to avoid querying mods for no reason.

[drtheodor]

This is rather confusing and will become more complicated if more filters are added.
I suggest the following:

Suggested change

	if (shownCategory != DisplayedCategories.STRUCTURES) {
	for (Identifier id : client.world.getRegistryManager().get(RegistryKeys.BIOME).getIds()) {
	this.entries.add(new Entry(id, true));
	}
	}
	if (shownCategory != DisplayedCategories.BIOMES) {
	for (Identifier id : AstralMapBlock.structureIds) {
	this.entries.add(new Entry(id, false));
	}
	}
	boolean both = DisplayedCategories.BOTH;
	if (shownCategory == DisplayedCategories.BIOMES || both) {
	for (Identifier id : client.world.getRegistryManager().get(RegistryKeys.BIOME).getIds()) {
	this.entries.add(new Entry(id, true));
	}
	}
	if (shownCategory == DisplayedCategories.STRUCTURES || both) {
	for (Identifier id : AstralMapBlock.structureIds) {
	this.entries.add(new Entry(id, false));
	}
	}

Alternatively, the enum could be replaced with a bitset (be it a normal int or BitSet, effectively allowing to combine values).

Alternatively no.2, you could add an abstract method to the enum that would supply the entries, something like this:

public enum DisplayedCategories {
    STRUCTURES {
        @Override
        public void getEntries(Consumer<AstralMapListWidget.Entry> consumer, MinecraftClient client) {
            for (Identifier id : AstralMapBlock.structureIds) {
                consumer.accept(new Entry(id, false));
            }
        }
    },
    BIOMES {
        @Override
        public void getEntries(Consumer<AstralMapListWidget.Entry> consumer, MinecraftClient client) {
            for (Identifier id : client.world.getRegistryManager().get(RegistryKeys.BIOME).getIds()) {
                consumer.accept(new Entry(id, true));
            }
        }
    },
    BOTH {
        @Override
        public void getEntries(Consumer<AstralMapListWidget.Entry> consumer, MinecraftClient client) {
            for (DisplayedCategories category : DisplayedCategories.VALUES) {
                category.getEntries(consumer, client);
            }
        }
    };

    private static final DisplayedCategories VALUES = values();

    public abstract void getEntries(Consumer<AstralMapListWidget.Entry> consumer, MinecraftClient client);
}

// ...

// in #refreshEntries:
this.shownCategory.getEntries(this.entries::add, client);

[drtheodor]

WorldUtil#fakeTranslate shouldn't throw exceptions. If it does, please wrap it in a try-catch.

[nanowuu]

I just left this bit as is from @duzos initial astral map commit

[drtheodor]

Having a hardcoded isBiome is kinda bad, since there could be other types added in future that could also have a translation.

In this scenario, I think the enum abstract method option I've mentioned previously would work the best, since then you could pass the Text directly to the Entry, instead of the Entry coming up with it.

[nanowuu]

Generally I would agree with you but what other types? I feel like the enum abstract method complicates things a bit too much for a hypothetical

[nanowuu]

Unless you have something in mind?

[drtheodor]

It doesn't complicate stuff that much, plus it allows to add other categories more easily. For example, we could add the home location as a category. Or, perhaps, the waypoints stored in waypoint banks.

Obviously, out of scope for this PR, but doing the enum abstract method and passing Texts directly would make it implementable without many changes.

[Addi3]

It doesn't complicate stuff that much, plus it allows to add other categories more easily. For example, we could add the home location as a category. Or, perhaps, the waypoints stored in waypoint banks.

never happening btw :al_clueless:

[drtheodor]

Should be an enum, ideally.

[duzos]

LARP final boss