fix: simplify sucking condition & suck harder#2006
Open
Conversation
drtheodor
added
T: Bugfix
github-actions
Bot
added
S: Untriaged
drtheodor
removed
the
S: Untriaged
Addi3
approved these changes
May 2, 2026
Collaborator
Addi3
left a comment
Addi3
left a comment
There was a problem hiding this comment.
LGTM - it can now suck again
github-actions
Bot
added
S: Approved
Member
Author
|
and suck it will |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
This PR fixes a problem of the door not sucking hard enough.
Why / Balance
Because it sucks.
Technical details
Simplified the suck conditions and change it to use the proper suck offset. Apparently, the direction was reversed, so the sign of the offset has to be positive.
Also, made it use
#toCenterPos, instead of creatingVec3dfrom theBlockPos' coordinates, since that would create a vector on the corner of the block which is not the intended behavior.Requirements
Changelog
🆑