Skip to content

chore: switch amblekit to dev.amble:lib 1.1.16-dev#67

Merged
duzos merged 1 commit intomasterfrom
chore/update-amblekit
May 2, 2026
Merged

chore: switch amblekit to dev.amble:lib 1.1.16-dev#67
duzos merged 1 commit intomasterfrom
chore/update-amblekit

Conversation

@duzos
Copy link
Copy Markdown
Member

@duzos duzos commented May 2, 2026

Migrates the amblekit dependency from the Modrinth-published maven.modrinth:amblekit:1.1.11-1.20.1-beta to the canonical dev.amble:lib:1.1.16-dev+mc.1.20.1 coordinates published at https://amblelabs.dev/maven, matching the pattern used by amblelabs/modkit (the source of amblekit itself) and amblelabs/ait (its largest consumer).

Changes

build.gradle

  • Added the https://amblelabs.dev/maven repository with includeGroup "dev.amble".
  • Replaced modImplementation("maven.modrinth:amblekit:${project.sakitus_version}") with modImplementation("dev.amble:lib:${project.amblekit_version}").
  • Migrated theo's maven from https://theo.is-a.dev/maven-repo/ to https://theo.is-a.dev/maven/ (the old URL now 404s) and scoped it to includeGroup "dev.drtheo". This is required because the new amblekit pulls in dev.drtheo:multidim, dev.drtheo:scheduler, and dev.drtheo:queue as transitive deps.
  • Added an explicit modImplementation("maven.modrinth:animator:${project.animator_version}") dep. The old amblekit bundled Animator transitively; the new dev.amble:lib does not, so Animator now needs to be declared directly. The codebase already imports from mc.duzo.animation.* in many places.

gradle.properties

  • Removed sakitus_version=1.1.11-1.20.1-beta.
  • Added amblekit_version=1.1.16-dev+mc.1.20.1 (latest stable from amblelabs.dev/maven).
  • Added animator_version=1.0.1.20-1.20.1-release (latest 1.20.1 release on Modrinth).

Verification

  • ./gradlew compileJava succeeds cleanly with only the pre-existing deprecation/unchecked warnings.
  • All dev.amble.lib.* and mc.duzo.animation.* imports in the codebase resolve against the new dependency stack.
  • No source code changes; this PR is build-config only.

Notes

  • This brings the project's dep stack in line with AIT, which makes future cross-pollination of fixes / pattern updates between the two mods easier.
  • The bump from 1.1.11 to 1.1.16-dev is several minor releases worth of changes; if any amblekit API has shifted under us in that range, it'll show up at compile or runtime. The clean compile suggests any drift is non-breaking for the surface this mod uses today.

- replace maven.modrinth:amblekit:1.1.11-1.20.1-beta with dev.amble:lib:1.1.16-dev+mc.1.20.1, matching the canonical pattern used by amblelabs/modkit and amblelabs/ait
- add the amblelabs.dev maven repo (includeGroup dev.amble)
- migrate theo's maven from /maven-repo/ to /maven/ (includeGroup dev.drtheo) so the new amblekit transitive deps (multidim, scheduler, queue) resolve
- add animator 1.0.1.20-1.20.1-release explicitly; the old amblekit was bundling it transitively, the new dev.amble:lib does not
Copilot AI review requested due to automatic review settings May 2, 2026 12:57
@github-actions github-actions Bot added C: No Java Changes: Requires no Java knowledge to review or fix this item. S: Untriaged labels May 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s build configuration to migrate the AmbleKit dependency from Modrinth coordinates to the canonical AmbleLabs Maven coordinates, and adds an explicit Animator dependency to match the new transitive dependency graph.

Changes:

  • Switch amblekit dependency coordinates to dev.amble:lib and add the AmbleLabs Maven repo (scoped to dev.amble).
  • Update Theo’s Maven URL and scope it to dev.drtheo for new transitive deps.
  • Add an explicit maven.modrinth:animator dependency and introduce animator_version / amblekit_version properties.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
gradle.properties Replaces sakitus_version with amblekit_version and adds animator_version.
build.gradle Adds scoped repos for AmbleLabs/Theo and updates dependencies to use dev.amble:lib plus explicit Animator.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@duzos
Copy link
Copy Markdown
Member Author

duzos commented May 2, 2026

Copilot's pass landed clean (no inline comments) — summary acknowledged. Build is green locally (./gradlew compileJava), and the dependency switch is mechanical (modrinth coords -> dev.amble:lib + transitive maven scopes). No code changes; ready for human review whenever convenient.

@duzos duzos merged commit 2789ebc into master May 2, 2026
6 of 7 checks passed
@duzos duzos deleted the chore/update-amblekit branch May 2, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: No Java Changes: Requires no Java knowledge to review or fix this item. S: Untriaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants