chore: add .github/CODEOWNERS routing all PRs to @amcheste#9
Merged
Conversation
Merged
3 tasks
amcheste
added a commit
to amcheste/mac-dev-setup
that referenced
this pull request
Apr 26, 2026
….0 (#75) ## Summary Two related corrections to the canonical Claude Code skills in this repo, bringing them in line with the conventions documented in [amcheste/engineering-handbook v0.1.0](https://github.com/amcheste/engineering-handbook/releases/tag/v0.1.0). ### \`claude-skills/setup-repo/SKILL.md\` Adds **Step 6: verify CODEOWNERS routing**. Without \`.github/CODEOWNERS\`, bot-authored PRs (via the \`amcheste-ai-agent\` GitHub App) don't auto-route to a human reviewer and disappear from review queues like Graphite. The new step checks for the file and surfaces the gap in the summary; \`setup-repo\` still doesn't write to the repo itself, so the remediation is a follow-up PR adding the file. **How this was found:** [overleaf-mcp#8](amcheste/overleaf-mcp#8) didn't show up in @amcheste's review queue. The repo had been through \`/setup-repo\` but never had \`CODEOWNERS\` added. [overleaf-mcp#9](amcheste/overleaf-mcp#9) is the follow-up PR adding the file. ### \`claude-skills/publish-release/SKILL.md\` Step 2 was opening a \`develop → main\` **GitHub PR** for the release promotion. That contradicts the rule documented in the [Branching Strategy philosophy §5](https://github.com/amcheste/engineering-handbook/blob/main/docs/philosophies/branching-strategy.md#5-releases-preserve-commit-ancestry--cli-merge-not-ui-merge) and in \`~/.claude/CLAUDE.md\`: GitHub's merge button squash-merges by default, which collapses commit ancestry and causes merge conflicts on every subsequent release. The fix is a CLI \`--no-ff\` merge. Step 2 now documents: \`\`\`bash git fetch origin git checkout main && git pull git merge --no-ff origin/develop -m "chore: release v<version>" git push origin main \`\`\` Also adds a **branch-protection note**: with \`enforce_admins: true\` + required-PR review (the standard \`setup-repo\` config), the CLI push to \`main\` is rejected. The skill now documents the toggle dance (disable, push, re-enable) and notes the App needs \`Administration: Read & Write\` to perform it. Same dance applies to the \`v*\` tag ruleset for Step 3. **Minor cleanup:** hardcoded \`mac-dev-setup\` URL in the Summary section becomes a \`<repo>\` placeholder. ## Test plan - [ ] CI (\`Lint\`, \`Commit Lint\`) passes. - [ ] Skills render cleanly when read by Claude Code. - [ ] After merge: re-sync local \`~/.claude/skills/\` from this repo (via your usual setup script) and run \`/setup-repo amcheste/<some-repo>\` to confirm Step 6 fires. ## Related - engineering-handbook v0.1.0 — release that codified these conventions. - overleaf-mcp#9 — concrete PR adding CODEOWNERS to a repo that was missing it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-Authored-By: amcheste <13696614+amcheste@users.noreply.github.com>
Without this file, App-authored PRs in this repo had no auto-routing to a human reviewer — they simply didn't appear in @amcheste's review queue (e.g. Graphite, GitHub's own review filter). This was visible on PR #8, which had no assignee, no reviewer, and no codeowner so it was effectively invisible. CODEOWNERS pattern matches every other repo in @amcheste's account and is the canonical wiring point referenced in the engineering handbook's Claude Bot Account design note. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-Authored-By: amcheste <13696614+amcheste@users.noreply.github.com>
amcheste-ai-agent
Bot
force-pushed
the
chore/add-codeowners
branch
from
d7ddfe1 to
b314648
Compare
amcheste
approved these changes
Apr 29, 2026
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repo had no `CODEOWNERS` file, which meant App-authored PRs (like #8) didn't auto-route to @amcheste for review. They simply weren't visible in his review queue (Graphite, GitHub's review-requested filter, etc.) until someone manually added a reviewer.
This PR fixes the gap.
`* @amcheste` matches the canonical wiring used in every other repo in this account, and pairs with the bot-account pattern described in the Claude Bot Account design note.
Effect after merge
Test plan
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com
Co-Authored-By: amcheste 13696614+amcheste@users.noreply.github.com