Adding ledger accounts and journal entries

[schapman1974]

Purpose

The PR adds ledger accounts and a business object to the api in order to support the account/businesses endpoint. The main focus of this is to add additional functionality to the sdk that is not currently exposed.

• list of ledger accounts get
• journal entries get / post
• journal entry details

[schapman1974]

@amcintosh Please review this draft and let me know if this is how you would want to implement ledger_accounts and journal entries from the client.py and the additional api/business.py

[amcintosh]

Hi @schapman1974!
Thank you so much for the contribution.

[amcintosh]

I don't think the ledger_accounts is working as expected. The result from most of the accounting endpoints is in the form of:

{
   "response": {
      "result": {
         "client": {
         }
      }
}

But for these new endpoints the result is in the form:

{
   "data": {
   }
}

So when you add the data to the model: https://github.com/amcintosh/freshbooks-python-sdk/pull/16/files#diff-cc8690904fb746159ca8b295604ae5606beb2130b5d626243c7ba954865216a5R88 the single_name is not present in the data and so you get an empty model here: https://github.com/amcintosh/freshbooks-python-sdk/blob/main/freshbooks/models.py#L54.

In the cases of this new set of accounting resources, I don't think we need single_name or list_name at all.

I think changing the __init__ to something like:

def __init__(self, client_config: SimpleNamespace, accounting_path: str,
                     delete_via_update: bool = True, missing_endpoints: Optional[List[str]] = None):

And then update https://github.com/amcintosh/freshbooks-python-sdk/pull/16/files#diff-cc8690904fb746159ca8b295604ae5606beb2130b5d626243c7ba954865216a5R88 to be:

return Result("data", data)

should work.

Something similar would need to be done for the list() call.

[amcintosh]

I think setting up some tests for the new resource set would help work out the differences.

[amcintosh]

Looks like you can only create journal entries, so missing_endpoints=["list", "get", "update", "delete"] should be added.