Merged
Conversation
Closed
Pull Request Test Coverage Report for Build 299
💛 - Coveralls |
Collaborator
|
Job #160 is now in scope, role is |
Collaborator
Contributor
Author
|
@amihaiemil ping |
Collaborator
Owner
|
@llorllale looks ok, thanks! Yes, I want filters to be merged. That is, if you call |
Owner
|
@rultor merge it |
Collaborator
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
Collaborator
@amihaiemil @llorllale Oops, I failed. You can see the full log here (spent 21s) |
Collaborator
|
Job |
Collaborator
|
The job #160 is now out of scope |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for #153:
Images.filter()inListedImagesRtImages.filter()I'm also not so sure what the merge strategy should be for these filters. This PR will simply substitute any previously specified filter's values, but I'm not sure if you wanted to actually merge the values of the filters.