Skip to content

For #206. Adding prune method to Volumes#210

Merged
rultor merged 3 commits intoamihaiemil:masterfrom
bkuzmic:issue-206-Volumes-prune
Dec 10, 2018
Merged

For #206. Adding prune method to Volumes#210
rultor merged 3 commits intoamihaiemil:masterfrom
bkuzmic:issue-206-Volumes-prune

Conversation

@bkuzmic
Copy link
Contributor

@bkuzmic bkuzmic commented Dec 7, 2018

For #206:

  • added prune method to Volumes
  • added unit tests for RtVolumes

@0crat
Copy link
Collaborator

0crat commented Dec 7, 2018

Job #210 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Dec 7, 2018

This pull request #210 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@coveralls
Copy link

coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 361

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.237%

Totals Coverage Status
Change from base Build 357: 0.2%
Covered Lines: 485
Relevant Lines: 569

💛 - Coveralls

Copy link
Contributor

@paulodamaso paulodamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkuzmic Just some cosmetic import changes, please take a look

@amihaiemil
Copy link
Owner

@bkuzmic @paulodamaso looks good, thanks! :) for the future, I don't think imports have to be in alphabetic order, we can skip this kind of cosmetic stuff.

@amihaiemil
Copy link
Owner

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented Dec 10, 2018

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 0b95a4f into amihaiemil:master Dec 10, 2018
@rultor
Copy link
Collaborator

rultor commented Dec 10, 2018

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)

@0crat
Copy link
Collaborator

0crat commented Dec 10, 2018

Quality is low, no payment, see §31:

@0crat
Copy link
Collaborator

0crat commented Dec 10, 2018

The job #210 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Dec 10, 2018

Job gh:amihaiemil/docker-java-api#210 doesn't exist in WBS, can't create order

@0crat
Copy link
Collaborator

0crat commented Dec 10, 2018

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z

@paulodamaso
Copy link
Contributor

paulodamaso commented Dec 11, 2018

@amihaiemil I did not received reputation payment for this one Why 0crat decided this one had bad quality?

@amihaiemil
Copy link
Owner

@paulodamaso Because you didn't leave any comment on it. I should have waited for your review, but I hurried, sorry :D

@paulodamaso
Copy link
Contributor

@amihaiemil no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants