Skip to content

For #205: Adding Volume delete and create methods#211

Merged
rultor merged 3 commits intoamihaiemil:masterfrom
bkuzmic:issue-205-Volume-create-remove
Dec 11, 2018
Merged

For #205: Adding Volume delete and create methods#211
rultor merged 3 commits intoamihaiemil:masterfrom
bkuzmic:issue-205-Volume-create-remove

Conversation

@bkuzmic
Copy link
Contributor

@bkuzmic bkuzmic commented Dec 10, 2018

For #205:

  • implementing delete and basic create method for Volumes API
  • creating testcases
  • creating new pdd to extend create method with more options (specify driver, driver options and labels)

@coveralls
Copy link

coveralls commented Dec 10, 2018

Pull Request Test Coverage Report for Build 365

  • 23 of 23 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 85.811%

Totals Coverage Status
Change from base Build 362: 0.6%
Covered Lines: 508
Relevant Lines: 592

💛 - Coveralls

@0crat
Copy link
Collaborator

0crat commented Dec 10, 2018

Job #211 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Dec 10, 2018

This pull request #211 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

Copy link
Contributor

@paulodamaso paulodamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkuzmic Please take a look at the comments

Copy link
Contributor

@paulodamaso paulodamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkuzmic I think that's all good now, thanks

@paulodamaso
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Dec 11, 2018

@rultor merge

@paulodamaso Thanks for your request. @amihaiemil Please confirm this.

@amihaiemil
Copy link
Owner

amihaiemil commented Dec 11, 2018

Thanks all!

@amihaiemil
Copy link
Owner

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented Dec 11, 2018

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit fdd74e2 into amihaiemil:master Dec 11, 2018
@rultor
Copy link
Collaborator

rultor commented Dec 11, 2018

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)

@0crat
Copy link
Collaborator

0crat commented Dec 11, 2018

Job was finished in 24 hours, bonus for fast delivery is possible (see §36)

@0crat
Copy link
Collaborator

0crat commented Dec 11, 2018

The job #211 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Dec 11, 2018

Order was finished: +20 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

0crat commented Dec 11, 2018

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants