For #268: Implementing Plugin upgrade() and push() methods

[bkuzmic]

For #268:

• Implementing upgrade() and push() methods
• Added new class ArrayPayloadOf to extract Json request as Iterator<JsonObject>
• Added new puzzles: to make tests for ArrayPayloadOf and to finish Plugin's configure() method

[0crat]

Job #280 is now in scope, role is REV

[coveralls]

Pull Request Test Coverage Report for Build 499

• 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.6%) to 90.449%

---

Totals
Change from base Build 496:	0.6%
Covered Lines:	786
Relevant Lines:	869

---

💛 - Coveralls

[0crat]

This pull request #280 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[amihaiemil]

@bkuzmic looks ok, just one comment. And there are some merge conflicts now :)

[amihaiemil]

@rultor merge it

[rultor]

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge it

@amihaiemil @bkuzmic Oops, I failed. You can see the full log here (spent 20s)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 24786
+ echo '1.68.1 24dc2a841'
1.68.1 24dc2a841
+ date
Wed Jan  9 10:36:36 CET 2019
+ uptime
 10:36:36 up 25 days,  1:06,  0 users,  load average: 5.80, 5.90, 5.98
+ ff=default
+ image=yegor256/java8
+ rebase=false
+ head_branch=master
+ pull_title='For #268: Implementing Plugin upgrade() and push() methods'
+ author=amihaiemil
+ directory=
+ head=git@github.com:amihaiemil/docker-java-api.git
+ pull_id=280
+ fork=git@github.com:bkuzmic/docker-java-api.git
+ fork_branch=issue-268-Plugin
+ squash=false
+ vars=('--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' '--env=head=git@github.com:amihaiemil/docker-java-api.git' '--env=pull_id=280' '--env=fork=git@github.com:bkuzmic/docker-java-api.git' '--env=fork_branch=issue-268-Plugin' '--env=head_branch=master' '--env=pull_title=For #268: Implementing Plugin upgrade() and push() methods' '--env=author=amihaiemil' '--env=scripts=( '\''export '\''\'\'''\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head=git@github.com:amihaiemil/docker-java-api.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=280'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:bkuzmic/docker-java-api.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=issue-268-Plugin'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=For #268: Implementing Plugin upgrade() and push() methods'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=amihaiemil'\''\'\'''\'''\'' '\'';'\'' '\''mvn clean install -Pcheckstyle'\'' '\'';'\'' )')
+ scripts=('export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ';' 'export '\''head=git@github.com:amihaiemil/docker-java-api.git'\''' ';' 'export '\''pull_id=280'\''' ';' 'export '\''fork=git@github.com:bkuzmic/docker-java-api.git'\''' ';' 'export '\''fork_branch=issue-268-Plugin'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=For #268: Implementing Plugin upgrade() and push() methods'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle' ';')
+ container=amihaiemil_docker-java-api_280
+ as_root=false
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:amihaiemil/docker-java-api.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ';' 'export '\''head=git@github.com:amihaiemil/docker-java-api.git'\''' ';' 'export '\''pull_id=280'\''' ';' 'export '\''fork=git@github.com:bkuzmic/docker-java-api.git'\''' ';' 'export '\''fork_branch=issue-268-Plugin'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=For #268: Implementing Plugin upgrade() and push() methods'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle' ';'
+ sensitive=()
+ gpgconf --reload gpg-agent
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
gpgkeys: key 9AF0FA4C can't be retrieved
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
gpg: keyserver communications error: keyserver helper general error
gpg: keyserver communications error: unknown pubkey algorithm
gpg: keyserver receive failed: unknown pubkey algorithm
'cid' file is absent, container wasn't started correctly

[0crat]

Job was finished in 19 hours, bonus for fast delivery is possible (see §36)

[0crat]

Quality is low, no payment, see §31:

[0crat]

The job #280 is now out of scope

[0crat]

Job gh:amihaiemil/docker-java-api#280 doesn't exist in WBS, can't create order

[0crat]

Job gh:amihaiemil/docker-java-api#280 doesn't exist in WBS, can't create order

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z