Conversation
Pull Request Test Coverage Report for Build 701
💛 - Coveralls |
amihaiemil
left a comment
amihaiemil
left a comment
There was a problem hiding this comment.
@jackpan123 Please see comments.
| @Override | ||
| public Container get(final String containerId) { | ||
| return new RtContainer( | ||
| Json.createObjectBuilder().build(), |
There was a problem hiding this comment.
@jackpan123 can you add the id to this JSON?
Json.createObjectBuilder()
.add("Id", containerId)
.build()| URI.create("http://localhost/test"), | ||
| Mockito.mock(Docker.class) | ||
| ).get("df2419f4").stop(); | ||
| } |
There was a problem hiding this comment.
@jackpan123 These 2 tests don't make sense. Why are you calling start and stop?
Just add a simple test only for the get(...) method and assert that a Container is being returned (not null) and that its JSON contains the ID.
There was a problem hiding this comment.
What get(...) method wants to express is that users cant directly obtain a certain container instead of iteratively searching. When the user finds it, who can directly manipulate the internal method of the Container .
|
@rultor merge it |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 2min) |
|
Job |
5 participants
fix #348