3.0.0 installation error

[dpo]

On OSX 10.9, I get the following when building release 3.0.0:

CMake Error at doc/cmake_install.cmake:31 (file):
  file INSTALL cannot find
  "/tmp/asl20160325-1399-1bc5h1m/mp-3.0.0/doc/ampl.github.io".
Call Stack (most recent call first):
  cmake_install.cmake:60 (include)

This is at 100% of the build; everything else went well. In doc/cmake_install.cmake, there is

if(NOT CMAKE_INSTALL_COMPONENT OR "${CMAKE_INSTALL_COMPONENT}" STREQUAL "Unspecified")
  file(INSTALL DESTINATION "${CMAKE_INSTALL_PREFIX}/share/doc/mp" TYPE DIRECTORY FILES "/tmp/asl20160325-1399-1bc5h1m/mp-3.0.0/doc/ampl.github.io/" REGEX "/\\.[^/]*$" EXCLUDE)
endif()

[vitaut]

Have you run make doc before make install? I can make doc installation optional, but this will only apply to the next version.

[dpo]

Sorry I didn't see that in the instructions. Now I have bigger problems:

cd /tmp/asl20160325-7775-l45v3b/mp-3.0.0/build/doc && python /tmp/asl20160325-7775-l45v3b/mp-3.0.0/support/build-docs.py
Traceback (most recent call last):
  File "/tmp/asl20160325-7775-l45v3b/mp-3.0.0/support/build-docs.py", line 147, in <module>
    build_docs('.')
  File "/tmp/asl20160325-7775-l45v3b/mp-3.0.0/support/build-docs.py", line 80, in build_docs
    create_virtualenv(os.path.join(workdir, 'build', 'virtualenv'))
  File "/tmp/asl20160325-7775-l45v3b/mp-3.0.0/support/build-docs.py", line 23, in create_virtualenv
    run('virtualenv', venv_dir)
  File "/tmp/asl20160325-7775-l45v3b/mp-3.0.0/support/build-docs.py", line 15, in run
    check_call(args, **kwargs)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 537, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 524, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1308, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

[vitaut]

Documentation building script requires virtualenv. I've added a new section that clarifies this to README here. Also installing the docs is now optional: 77b2db5

Thanks for catching this!

[dpo]

Thanks. For the record, I do have virtualenv, but it's not picked up because CMake picks up system Python. I have virtualenv with Homebrew Python (which appears first on my PATH).

[vitaut]

It's a bit weird that CMake doesn't pick up the first python executable on the PATH. I can add a call to

find_package(PythonInterp)

and use PYTHON_EXECUTABLE instead of just python if you like. This might solve the problem or at least give a way to specify which python to use.

[dpo]

Personally, I'd rather leave Python out of the mix. What's the CMake option to deactivate building the docs?

[vitaut]

The docs are not built by default. The problem is that in 3.0 they are included in installation. I don't think there is an option to control this, but you can apply this simple fix: 77b2db5

[dpo]

Thanks. With your simple fix, it builds. Unfortunately, #65 isn't in there.

[vitaut]

Looks like #65 was submitted to branch 2.0, not master. Is there any reason for that and do you want me to merge it into master?

[dpo]

Yes it would be great to have it in master. I assumed the 2.0 branch would be merged into master at some point.

[vitaut]

I've cherry-picked the two commits from #65 into master and removed branch 2.0 to avoid confusion and since versions 2.x are no longer supported. If you want I can tag version 3.1 which will include the fixes discussed here.

[dpo]

Many thanks @vitaut! It would be great to tag a new release, if you're ready.

[vitaut]

Done: https://github.com/ampl/mp/releases/tag/3.1.0. Thanks again for reporting the issues.